Computer
McKinsey Wonders How To Sell AI Apps With No Measurable Benefits
Read more of this story at Slashdot.
China Confirms Solar Panel Projects Are Irreversibly Changing Desert Ecosystems
Read more of this story at Slashdot.
One-Man Spam Campaign Ravages EU 'Chat Control' Bill
Read more of this story at Slashdot.
UK's Central Bank Warns of Growing Risk That AI Bubble Could Burst
Read more of this story at Slashdot.
Discord Says 70,000 Users May Have Had Their Government IDs Leaked In Breach
Read more of this story at Slashdot.
Internet Archive Ordered to Block Books in Belgium
Read more of this story at Slashdot.
The World's Biggest Citizen Science Project
Read more of this story at Slashdot.
CodeSOD: A JSON Serializer
Carol sends us today's nasty bit of code. It does the thing you should never do: serializes by string munging.
public string ToJSON() { double unixTimestamp = ConvertToMillisecondsSinceEpoch(time); string JSONString = "{\"type\":\"" + type + "\",\"data\":{"; foreach (string key in dataDict.Keys) { string value = dataDict[key].ToString(); string valueJSONString; double valueNumber; bool valueBool; if (value.Length > 2 && value[0].Equals('(') && value[value.Length - 1].Equals(')')) //tuples { char[] charArray = value.ToCharArray(); charArray[0] = '['; charArray[charArray.Length - 1] = ']'; if (charArray[charArray.Length - 2].Equals(',')) charArray[charArray.Length - 2] = ' '; valueJSONString = new string(charArray); } else if ((value.Length > 1 && value[0].Equals('{') && value[value.Length - 1].Equals('}')) || (double.TryParse(value, out valueNumber))) //embedded json or numbers { valueJSONString = value; } else if (bool.TryParse(value, out valueBool)) //bools { valueJSONString = value.ToLower(); } else //everything else is a string { valueJSONString = "\"" + value + "\""; } JSONString = JSONString + "\"" + key + "\":" + valueJSONString + ","; } if (dataDict.Count > 0) JSONString = JSONString.Substring(0, JSONString.Length - 1); JSONString = JSONString + "},\"time\":" + unixTimestamp.ToString() + "}"; return JSONString; }Now, it's worth noting, C# already has some pretty usable JSON serialization built-ins. None of this code needs to exist in the first place. It's parsing across a dictionary, but that dictionary is itself constructed by copying properties out of an object.
What's fun in this is because everything's shoved into the dictionary and then converted into strings (for the record, the dictionary stores objects, not strings) the only way they have for sniffing out the type of the input is to attempt to parse the input.
If it starts and ends with a (), we convert it into an array of characters. If it starts and ends with {} or parses as a double, we just shove it into the output. If it parses as a boolean, we convert it to lower case. Otherwise, we throw ""s around it and put that in the output. Notably, we don't do any further escaping on the string, which means strings containing " could do weird things in our output.
The final delight to this is the realization that their method of handling appending will include an extra comma at the end, which needs to be removed. Hence the if (dataDict.Count > 0) check at the end.
As always, if you find yourself writing code to generate code, stop. Don't do it. If you find you actually desperately need to start by building a syntax tree, and only then render it to text. If you find yourself needing to generate JSON specifically, please, I beg you, just get a library or use your language's built-ins.
[Advertisement] Plan Your .NET 9 Migration with ConfidenceYour journey to .NET 9 is more than just one decision.Avoid migration migraines with the advice in this free guide. Download Free Guide Now!
EU Lawmakers Push To Ban Plant-Based Food Terms
Read more of this story at Slashdot.
Germany To Allow Police To Shoot Down Drones
Read more of this story at Slashdot.
Polymarket Founder Is Youngest Self-Made Billionaire After Deal With NYSE Owner
Read more of this story at Slashdot.
Verizon Buys ISP Starry To Expand Wireless Broadband
Read more of this story at Slashdot.
Teens Arrested In London Preschool Ransomware Attack
Read more of this story at Slashdot.
PC Sales Explode In Q3 As Windows 11 Deadlines Force Millions To Upgrade
Read more of this story at Slashdot.
Amazon Installing Automated Medication Kiosks At Clinics
Read more of this story at Slashdot.
Insurers Balk At Paying Out Huge Settlements For Claims Against AI Firms
Read more of this story at Slashdot.
Salesforce Says It Won't Pay Extortion Demand in 1 Billion Records Breach
Read more of this story at Slashdot.
National Security Threatened By Climate Crisis, UK Intelligence Chiefs Due To Warn
Read more of this story at Slashdot.
Nobel Prize in Chemistry Awarded To Architects of Metal-Organic Frameworks
Read more of this story at Slashdot.
Logitech Will Brick Its $100 Pop Smart Home Buttons on October 15
Read more of this story at Slashdot.