Feed aggregator
Amazon Must Face US Nationwide Class Action Over Third-Party Sales
Read more of this story at Slashdot.
Common Pesticide Linked To Widespread Brain Abnormalities In Children
Read more of this story at Slashdot.
World's Biggest Iceberg Breaks Up After 40 Years
Read more of this story at Slashdot.
CodeSOD: Adding to the Argument
David G saw a pull request with a surprisingly long thread of comments on it. What was weirder was that the associated ticket was all about adding a single parameter to an existing method. What could be generating that much discussion?
How could adding an argument add to an argument?
registerFooWrapper: function(arg1, arg2, arg3, arg4, arg5, arg6, arg7) { bar.when('bar-event', function(context) { context.foo({ arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4, arg5: arg5, arg6: arg6, arg7: arg7, }); }); }This is the original version of the JavaScript function. The parameter names have been anonymized. That aside, this still isn't very good. Seven parameters is likely too many, and based on what I see in setting the context, there is an object type that holds them all, so maybe we should be passing the object around in the first place? Still, this isn't a WTF by any stretch, and since it's already deployed code, changing the interface significantly is a bad idea- maybe just adding a parameter is the right choice here. So what generated so much discussion?
This revision:
registerFooWrapper: function(arg1, arg2, arg3, arg4, arg5, arg6, arg7, notArg8) { if (notArg8 === true) { bar.when('bar-event', function(context) { context.foo({ arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4, arg5: arg5, arg6: arg6, arg7: arg7, arg8: !notArg8, }); }); } else { bar.when('bar-event', function(context) { context.foo({ arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4, arg5: arg5, arg6: arg6, arg7: arg7 }); }); } }Okay, so if notArg8 is true, we pass false to the context. If it's any other value, we don't past arg8 at all. I do not understand what I'm looking at here. If the goal is to ensure that arg8 is either true or not set, there are clearer ways to express that idea. But also, the goal of the ticket was not to do that- it was simply to add another parameter, which means you could drop the condition entirely and just add the parameter. context was already receiving arg8 as undefined, so it could clearly handle an undefined value.
David made some comments on the pull request, but the original developer just ended up going radio silent on it. One of the juniors on David's team approved it, for some reason, but nobody ever actually hit merge. Instead, a different developer simply made a version that took arg8 as a parameter, passed it down to context, and called it a day. It worked, the tests passed, and everyone was happy.
Well, except the original developer, but again, who knows what they were trying to do?
[Advertisement] ProGet’s got you covered with security and access controls on your NuGet feeds. Learn more.AI-Powered Drone Swarms Have Now Entered the Battlefield
Read more of this story at Slashdot.
Dozens of Scientists Find Errors in a New Energy Department Climate Report
Read more of this story at Slashdot.
Waymo Expands to Denver and Seattle
Read more of this story at Slashdot.
Paramount and Activision Team For 'Call of Duty' Movie
Read more of this story at Slashdot.
Frostbyte10 Bugs Put Thousands of Refrigerators At Major Grocery Chains At Risk
Read more of this story at Slashdot.
Chrome Increases Its Overwhelming Market Share, Now Over 70%
Read more of this story at Slashdot.
SAP To Invest Over 20 Billion Euros In 'Sovereign Cloud'
Read more of this story at Slashdot.
OpenAI To Acquire Product Testing Startup Statsig, Appoints CTO of Applications
Read more of this story at Slashdot.
Google Gets To Keep Chrome But Is Barred From Exclusive Search Deals, Judge Rules
Read more of this story at Slashdot.
Hackers Threaten To Submit Artists' Data To AI Models If Art Site Doesn't Pay Up
Read more of this story at Slashdot.
New Study Proves EVs Are Always Cleaner Than Gas Cars
Read more of this story at Slashdot.
Summer 2025 is the Warmest on Record for the UK
Read more of this story at Slashdot.
Laravel Inventor Tells Devs To Quit Writing 'Cathedrals of Complexity'
Read more of this story at Slashdot.
Poor Amazon Rains Linked To Brazil Deforestation
Read more of this story at Slashdot.
YouTube Is Pausing Premium Family Plans if You Aren't Watching From the Same Address
Read more of this story at Slashdot.
32GB of RAM On Track To Become the New Majority For Gamers
Read more of this story at Slashdot.